Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adoptium.net-2239] sometimes the contributor component is empty #2240

Conversation

xavierfacq
Copy link
Member

@xavierfacq xavierfacq commented Sep 20, 2023

Description of change

Reported issue is #2239

To fix the problem of empty contributor component, we have to store (in window.localStorage) information about
the current repository (repoToCheck). Else we are trying to retrieve a random page of a smaller repository.

Checklist

  • npm test passes

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 36ac75f
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/650aa6e6f4a91700087606f2
😎 Deploy Preview https://deploy-preview-2240--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #2240 (36ac75f) into main (a3d1803) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2240   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          87       87           
  Lines        6515     6517    +2     
  Branches      553      553           
=======================================
+ Hits         6463     6465    +2     
  Misses         52       52           
Files Changed Coverage Δ
src/hooks/useAdoptiumContributorsApi.tsx 94.11% <100.00%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xavierfacq xavierfacq marked this pull request as ready for review September 20, 2023 08:08
@gdams gdams linked an issue Sep 20, 2023 that may be closed by this pull request
@tellison
Copy link
Contributor

Happy to see this fix - thanks @xavierfacq

@xavierfacq xavierfacq merged commit 32c926b into adoptium:main Sep 20, 2023
10 checks passed
@xavierfacq xavierfacq deleted the fix/adoptium.net-2239_sometimes_contributor_component_is_empty branch September 24, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes the Contributor component is empty
3 participants