Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Echancement Ideas #1573

Closed
wants to merge 1 commit into from
Closed

Conversation

pandenaman007
Copy link

@pandenaman007 pandenaman007 commented Mar 8, 2023

Description of change

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

@netlify
Copy link

netlify bot commented Mar 8, 2023

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 0cf5ce1
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/6408d37ae63d0a00089c740d
😎 Deploy Preview https://deploy-preview-1573--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@karianna
Copy link
Contributor

karianna commented Mar 9, 2023

@pandenaman007 - I think you can just add this text to an issue as opposed to commiting a file

Copy link
Member

@gdams gdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this doesn't look right...

@pandenaman007
Copy link
Author

@pandenaman007 - I think you can just add this text to an issue as opposed to commiting a file
Okay Sir, Sorry for the inconvenience Actually I had replied to the issue but did not get any response that's why I had made a pull request. Please guide me through this. Thank You.

@karianna karianna closed this Mar 10, 2023
@karianna
Copy link
Contributor

@pandenaman007 which issue number is it?

@pandenaman007
Copy link
Author

Sir the issue number is #1561.

@gdams
Copy link
Member

gdams commented Mar 10, 2023

Sir the issue number is #1561.

We don't typically create a file like this (perhaps you do in another OSS project)

Please just raise a PR with the code changes and we will review them. Thanks!

@pandenaman007
Copy link
Author

Okay sir I will do it. Thanks for your kind support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants