Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website i18n refactor #1485

Merged
merged 3 commits into from
Feb 9, 2023
Merged

website i18n refactor #1485

merged 3 commits into from
Feb 9, 2023

Conversation

gdams
Copy link
Member

@gdams gdams commented Feb 9, 2023

Description of change

This change partially implements the i18n fixes I worked on in #1397.

Currently the i18n library doesn't work in the way we'd expect it to as it appends /index.lang to the path. E.g /docs/faq is localized as /de/docs/faq/index.de. This change fixes the rewrites to make the page named /de/docs/faq

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

@netlify
Copy link

netlify bot commented Feb 9, 2023

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 5f93a4e
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/63e4f86cba293a00081f333d
😎 Deploy Preview https://deploy-preview-1485--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #1485 (e0fc1cf) into main (da0a891) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head e0fc1cf differs from pull request most recent head 5f93a4e. Consider uploading reports for the commit 5f93a4e to get more accurate results

@@            Coverage Diff             @@
##             main    #1485      +/-   ##
==========================================
- Coverage   92.60%   92.59%   -0.01%     
==========================================
  Files          81       81              
  Lines        5812     5806       -6     
  Branches      514      514              
==========================================
- Hits         5382     5376       -6     
  Misses        430      430              
Impacted Files Coverage Δ
src/__fixtures__/page.tsx 100.00% <100.00%> (ø)
src/templates/asciidocTemplate.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@hendrikebbers hendrikebbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea about the JS code (Gatsby config, build) :D but the Netlify preview looks good.

content/asciidoc-pages/docs/faq/index.es.adoc Show resolved Hide resolved
locales/i18n.js Show resolved Hide resolved
Copy link
Contributor

@zdtsw zdtsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gdams gdams merged commit 50e5dbe into adoptium:main Feb 9, 2023
@gdams gdams deleted the adoc branch February 9, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants