-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website i18n refactor #1485
website i18n refactor #1485
Conversation
✅ Deploy Preview for eclipsefdn-adoptium ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #1485 +/- ##
==========================================
- Coverage 92.60% 92.59% -0.01%
==========================================
Files 81 81
Lines 5812 5806 -6
Branches 514 514
==========================================
- Hits 5382 5376 -6
Misses 430 430
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea about the JS code (Gatsby config, build) :D but the Netlify preview looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test with
Description of change
This change partially implements the i18n fixes I worked on in #1397.
Currently the i18n library doesn't work in the way we'd expect it to as it appends
/index.lang
to the path. E.g/docs/faq
is localized as/de/docs/faq/index.de
. This change fixes the rewrites to make the page named/de/docs/faq
Checklist
npm test
passes