Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed view/Dependencies from asmtools URL #644

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Removed view/Dependencies from asmtools URL #644

merged 1 commit into from
Nov 29, 2024

Conversation

IamLRBA
Copy link
Contributor

@IamLRBA IamLRBA commented Nov 29, 2024 •
edited by smlambert
Loading

llxia
llxia approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. However, could you use Git keywords to automatically close the issues?
See Commit message example in https://github.com/adoptium/aqa-tests/blob/master/Contributing.md

@llxia llxia self-requested a review November 29, 2024 14:03
smlambert
smlambert approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the 'closes' remark and will merge. Thanks @IamLRBA !

@smlambert smlambert merged commit 4ab5104 into adoptium:master Nov 29, 2024
3 checks passed
@IamLRBA
Copy link
Contributor Author

IamLRBA commented Nov 29, 2024

I've added the 'closes' remark and will merge. Thanks @IamLRBA !

Thank you for the opportunity @smlambert, I will be on the lookout for other "good first issue" issues to help me contribute more to the community.

@smlambert
Copy link
Contributor

I will be on the lookout for other "good first issue" issues to help me contribute more to the community.

That will be wonderful @IamLRBA ... if you like to do more, we can pick out a few slightly bigger tasks to involve you in. For example, it would be good to address this one, #363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

@karianna karianna karianna approved these changes

@llxia llxia Awaiting requested review from llxia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove view/Dependencies from asmtools URL
4 participants
@IamLRBA @smlambert @karianna @llxia