Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed view/Dependencies from asmtools URL #643

Closed
wants to merge 1 commit into from

Conversation

IamLRBA
Copy link
Contributor

@IamLRBA IamLRBA commented Nov 28, 2024

As per the issue 546
cc
@llxia
@smlambert

@karianna karianna requested review from smlambert and llxia November 28, 2024 04:38
@llxia
Copy link
Contributor

llxia commented Nov 28, 2024

Thanks @IamLRBA . Please remove your unrelated local changes

image

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shafn => 'asmtools.jar.sha256sum.txt',
shaalg => '256'
},
url => 'https://ci.adoptium.net/job/dependency_pipeline/lastSuccessfulBuild/artifact/asmtools/asmtools-core-7.0.b10-ea.jar',
Copy link
Contributor

@llxia llxia Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indentation. The original indentation is correct.

@IamLRBA IamLRBA closed this by deleting the head repository Nov 28, 2024
@IamLRBA
Copy link
Contributor Author

IamLRBA commented Nov 29, 2024

I have created a new PR that should have the corrections addressed. You could look at it.
Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants