Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use tools.jar from java.home lib" #141

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Revert "Use tools.jar from java.home lib" #141

merged 1 commit into from
Nov 22, 2024

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Nov 22, 2024

@llxia llxia requested a review from LongyuZhang November 22, 2024 15:07
@llxia llxia mentioned this pull request Nov 22, 2024
Open
@llxia llxia requested a review from smlambert November 22, 2024 15:15
LongyuZhang
LongyuZhang approved these changes Nov 22, 2024
View reviewed changes
Copy link

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit 5b80d94 into master Nov 22, 2024
1 check passed
@keithc-ca
Copy link
Contributor

Could someone please delete the now-merged branch revert-140-mauveSTF? Thanks.

@llxia llxia deleted the revert-140-mauveSTF branch November 26, 2024 13:34
@llxia
Copy link
Contributor Author

llxia commented Nov 26, 2024

Done

@llxia llxia mentioned this pull request Nov 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LongyuZhang LongyuZhang LongyuZhang approved these changes

@smlambert smlambert Awaiting requested review from smlambert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@llxia @keithc-ca @LongyuZhang