Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow @ember/test-helpers 3 #518

Merged

Conversation

francois2metz
Copy link
Contributor

@francois2metz francois2metz commented Aug 23, 2023

@ember/test-helpers v3 has been released for a while.

@francois2metz francois2metz force-pushed the flex-ember-test-helpers branch from 4b4290d to b4a27c6 Compare August 23, 2023 14:21
@francois2metz
Copy link
Contributor Author

Not sure which pnpm version was used to generate the lockfile. I setup [email protected], instead of the last one 8. It should works now.

@francois2metz francois2metz force-pushed the flex-ember-test-helpers branch from 8db39dc to e3d9237 Compare September 18, 2023 15:22
@francois2metz francois2metz force-pushed the flex-ember-test-helpers branch from e3d9237 to bbbefff Compare September 18, 2023 20:15
@francois2metz
Copy link
Contributor Author

I fixed a small when running tests with @ember/test-helpers v3. Should be good now!

@francois2metz francois2metz force-pushed the flex-ember-test-helpers branch from bbbefff to 992e983 Compare September 19, 2023 07:29
@francois2metz
Copy link
Contributor Author

Is there is any chance to merge it?

@knownasilya
Copy link
Contributor

@francois2metz should it pass in ember-release?

@knownasilya
Copy link
Contributor

Rerunning the tests made it pass, and it didn't seem related to your changes.

@knownasilya knownasilya merged commit a68ab01 into adopted-ember-addons:master Sep 23, 2023
15 checks passed
@francois2metz francois2metz deleted the flex-ember-test-helpers branch September 23, 2023 14:49
@KroneckerDeIta
Copy link

Can a release with these changes be published please? I am upgrading my project to Ember 5.4 and I am having to put the following into my package.json file so that an npm install goes through:

"overrides": {
    "ember-sortable": {
        "@ember/test-helpers": "^3.2.0",
        "ember-source": "~5.4.0"
    }
}

@github-actions github-actions bot mentioned this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants