fix types for reorder and drag test helpers

adopted-ember-addons · Sep 27, 2024 · b35613c · b35613c
1 parent a5edc3e
commit b35613c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/addon/src/test-support/helpers/drag.ts b/addon/src/test-support/helpers/drag.ts
@@ -37,7 +37,7 @@ interface Callbacks {
 
 export async function drag(
   mode: TMode,
-  itemSelector: string,
+  itemSelector: keyof (HTMLElementTagNameMap | SVGElementTagNameMap) | string, // or Parameters<typeof find>[0][]
   offsetFn: () => { dx: number; dy: number },
   callbacks: Callbacks = {},
 ) {

diff --git a/addon/src/test-support/helpers/reorder.ts b/addon/src/test-support/helpers/reorder.ts
@@ -26,10 +26,10 @@ const OVERSHOOT = 2;
     selectors for the resultant order
   @return {Promise}
 */
-export async function reorder<T extends keyof HTMLElementTagNameMap>(
+export async function reorder(
   mode: TMode,
-  itemSelector: string,
-  ...resultSelectors: T[]
+  itemSelector: keyof (HTMLElementTagNameMap | SVGElementTagNameMap) | string, // or Parameters<typeof findAll>[0],
+  ...resultSelectors: (keyof (HTMLElementTagNameMap | SVGElementTagNameMap) | string)[] // or Parameters<typeof find>[0][]
 ) {
   for (let targetIndex = 0; targetIndex < resultSelectors.length; targetIndex++) {
     const items = findAll(itemSelector);