Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: migrates url references to adopted-ember-addons. #1274

Merged

Conversation

matthewhartstonge
Copy link
Contributor

fixes up the urls due to adoption.

@matthewhartstonge matthewhartstonge changed the title docs: migrates url references to ember-adopted-addons. docs: migrates url references to adopted-ember-addons. Oct 17, 2024
Copy link
Collaborator

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 2 things that I think need changing before merge

README.md Outdated
@@ -2,7 +2,7 @@

This project aims to bring Google's new [Material Design](https://www.google.com/design/spec/material-design/introduction.html) to Ember. The goal is to encapsulate everything possible in Ember components. This project is packaged as an [Ember-cli](http://www.ember-cli.com/) addon.

[Explore Ember Paper docs »](https://miguelcobain.github.io/ember-paper/)
[Explore Ember Paper docs »](https://adopted-ember-addons.github.io/ember-paper/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is now actually https://ember-paper.netlify.app so that we can get deploy previews on PRs 💪

@@ -80,7 +80,7 @@
</p>
<p>
{{!-- Place this tag where you want the button to render. --}}
<a class="github-button" href="https://github.com/miguelcobain/ember-paper" data-style="mega" data-count-href="/miguelcobain/ember-paper/network" data-count-api="/repos/miguelcobain/ember-paper#forks_count">Fork</a>
<a class="github-button" href="https://github.com/adopted-ember-addons/ember-paper" data-style="mega" data-count-href="/adopted-ember-addons/ember-paper/network" data-count-api="/repos/adopted-ember-addons/ember-paper#forks_count">Fork</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these links might need to be changed 🤔 if you rebase this on origin/main you should get a preview for this PR and you can check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the button API has definitely changed a little! 😂

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for ember-paper ready!

Name Link
🔨 Latest commit 8b01248
🔍 Latest deploy log https://app.netlify.com/sites/ember-paper/deploys/671762e9a3b5760008aa0f2b
😎 Deploy Preview https://deploy-preview-1274--ember-paper.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tests/dummy/app/index.html Outdated Show resolved Hide resolved
@mansona mansona merged commit 717a72c into adopted-ember-addons:main Oct 23, 2024
8 of 13 checks passed
@github-actions github-actions bot mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants