-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: migrates url references to adopted-ember-addons. #1274
docs: migrates url references to adopted-ember-addons. #1274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just 2 things that I think need changing before merge
README.md
Outdated
@@ -2,7 +2,7 @@ | |||
|
|||
This project aims to bring Google's new [Material Design](https://www.google.com/design/spec/material-design/introduction.html) to Ember. The goal is to encapsulate everything possible in Ember components. This project is packaged as an [Ember-cli](http://www.ember-cli.com/) addon. | |||
|
|||
[Explore Ember Paper docs »](https://miguelcobain.github.io/ember-paper/) | |||
[Explore Ember Paper docs »](https://adopted-ember-addons.github.io/ember-paper/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is now actually https://ember-paper.netlify.app so that we can get deploy previews on PRs 💪
tests/dummy/app/templates/index.hbs
Outdated
@@ -80,7 +80,7 @@ | |||
</p> | |||
<p> | |||
{{!-- Place this tag where you want the button to render. --}} | |||
<a class="github-button" href="https://github.com/miguelcobain/ember-paper" data-style="mega" data-count-href="/miguelcobain/ember-paper/network" data-count-api="/repos/miguelcobain/ember-paper#forks_count">Fork</a> | |||
<a class="github-button" href="https://github.com/adopted-ember-addons/ember-paper" data-style="mega" data-count-href="/adopted-ember-addons/ember-paper/network" data-count-api="/repos/adopted-ember-addons/ember-paper#forks_count">Fork</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these links might need to be changed 🤔 if you rebase this on origin/main you should get a preview for this PR and you can check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the button API has definitely changed a little! 😂
a2ca8ce
to
d463dae
Compare
✅ Deploy Preview for ember-paper ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5798f83
to
4d6827c
Compare
Co-authored-by: Chris Manson <[email protected]>
fixes up the urls due to adoption.