Edit container height calculation #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both `containerHeight` and `nowrapHeight` calculations utilize inline display, which I think results in a more accurate `totLines` (saw a need for this in text ~3–4 lines long)
|
Thanks for submitting a pull request! I'm leaving on summer break soon, so not sure when I'll be able to look at this. It would be awesome if you could find a case that this fixes and create a simple test file in |
|
After looking into it, I actually wasn't able to replicate the miscalculation this intended to fix in a simplified test case. I am, however, using a custom web font so this very well could be related to #80. Apologies for the premature pull request! |
|
Thanks for followup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Edit so that both
containerHeightandnowrapHeightcalculations now utilize inline display, which I think results in a more accuratetotLines(saw a need for this in text ~3–4 lines long). Might be mistaken however, but I found it fixes issues I was seeing where total line count was jumping unnecessarily high.Types of changes
Checklist: