Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit container height calculation #145

Closed
wants to merge 1 commit into from

Conversation

justinjaywang
Copy link

Description

Edit so that both containerHeight and nowrapHeight calculations now utilize inline display, which I think results in a more accurate totLines (saw a need for this in text ~3–4 lines long). Might be mistaken however, but I found it fixes issues I was seeing where total line count was jumping unnecessarily high.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA. ->
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Both `containerHeight` and `nowrapHeight` calculations utilize inline display, which I think results in a more accurate `totLines` (saw a need for this in text ~3–4 lines long)
@redmunds
Copy link
Contributor

Thanks for submitting a pull request! I'm leaving on summer break soon, so not sure when I'll be able to look at this. It would be awesome if you could find a case that this fixes and create a simple test file in /test folder.

@justinjaywang
Copy link
Author

After looking into it, I actually wasn't able to replicate the miscalculation this intended to fix in a simplified test case. I am, however, using a custom web font so this very well could be related to #80.

Apologies for the premature pull request!

@justinjaywang justinjaywang deleted the patch-1 branch July 1, 2021 04:47
@redmunds
Copy link
Contributor

redmunds commented Jul 1, 2021

Thanks for followup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants