Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add the plugin system to the project #275

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: add the plugin system to the project #275

wants to merge 2 commits into from

Conversation

ramboz
Copy link
Collaborator

@ramboz ramboz commented Oct 31, 2023 •
edited
Loading

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Oct 31, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Oct 31, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@ramboz ramboz mentioned this pull request Oct 31, 2023
Closed
rofe
rofe requested changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@rofe rofe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The aem.js changes should be in https://github.com/adobe/aem-lib

@ramboz
Copy link
Collaborator Author

ramboz commented Nov 1, 2023

@rofe and they are 😉 adobe/aem-lib#23
The changes here are a copy/paste of the aem-lib build from that branch

@rofe
Copy link
Contributor

rofe commented Nov 1, 2023

Ok, then I suggest to let's park this PR until adobe/aem-lib#23 is approved and merged.

@ramboz ramboz marked this pull request as draft November 1, 2023 10:34
@ramboz
Copy link
Collaborator Author

ramboz commented Nov 1, 2023

@rofe ok moving it back to a draft PR then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rofe rofe rofe requested changes

@kptdobe kptdobe Awaiting requested review from kptdobe

@davidnuescheler davidnuescheler Awaiting requested review from davidnuescheler

@fkakatie fkakatie Awaiting requested review from fkakatie

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramboz @rofe