-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update istore for pg16 compatibility #113
Conversation
@rapimo 's solution. #ifndef SET_VARSIZE /* * pg >= 16 reorganized the toastable header files * postgres/postgres@d952373 * to ensure cross version compatibility we do a bit of a hack here */ #include "varatt.h" #endif
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Can you add Postgres 16 into the tests?
istore/.github/workflows/main.yml
Line 14 in 8a43a60
pg: [15, 14, 13, 12, 11, 10] |
Thanks @za-arthur for review and suggestion, I added 16 test but failed, |
Do you mean you couldn't add new version? What is necessary to do is to add
|
add pg16 to tests
Here is the error:
|
Sorry @za-arthur, I confused with pg-base62, but I added 16 test to CI and this repo has failed with pg16 test, I will take care next week both. |
@rapimo 's solution.
#ifndef SET_VARSIZE
/*
#endif