Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update istore for pg16 compatibility #113

Merged
merged 7 commits into from
Mar 1, 2024
Merged

Conversation

ridvankorkmaz
Copy link
Contributor

@rapimo 's solution.

#ifndef SET_VARSIZE
/*

  • pg >= 16 reorganized the toastable header files
  • postgres/postgres@d952373
  • to ensure cross version compatibility we do a bit of a hack here */ #include "varatt.h"
    #endif

@rapimo 's solution.

#ifndef SET_VARSIZE
/*
 * pg >= 16 reorganized the toastable header files
 * postgres/postgres@d952373
 * to ensure cross version compatibility we do a bit of a hack here
 */
#include "varatt.h"
#endif
@ridvankorkmaz ridvankorkmaz requested review from rapimo and a team February 8, 2024 20:19
Copy link
Contributor

@za-arthur za-arthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Can you add Postgres 16 into the tests?

pg: [15, 14, 13, 12, 11, 10]

@ridvankorkmaz
Copy link
Contributor Author

Thanks @za-arthur for review and suggestion, I added 16 test but failed,
If you had any quick fix let me know, otherwise next week I have to investigate th reason.

@za-arthur
Copy link
Contributor

Do you mean you couldn't add new version?

What is necessary to do is to add 16 here:

pg: [16, 15, 14, 13, 12, 11, 10] 

add pg16 to tests
@za-arthur
Copy link
Contributor

Here is the error:

src/bigistore.c:765:50: error: passing argument 1 of ‘PointerGetDatum’ makes pointer from integer without a cast [-Werror=int-conversion]

@ridvankorkmaz
Copy link
Contributor Author

Thanks @za-arthur for review and suggestion, I added 16 test but failed, If you had any quick fix let me know, otherwise next week I have to investigate th reason.

Sorry @za-arthur, I confused with pg-base62, but I added 16 test to CI and this repo has failed with pg16 test, I will take care next week both.

@PerikAdjust PerikAdjust changed the title Update istore.h Update istore for pg16 compatibility Mar 1, 2024
@ridvankorkmaz ridvankorkmaz merged commit 6c4c431 into master Mar 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants