Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THC 900 investigate smartling file paths #451

Merged
merged 8 commits into from
Feb 20, 2024

Conversation

bzavhorodskyi
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 11:28pm

@Sporiff
Copy link
Contributor

Sporiff commented Feb 19, 2024

@bzavhorodskyi I've pushed a commit which would enable us to pick up files without the locale code appended. My thinking is this:

  • The pickup rule is src/content/docs/**/*.mdx
  • The replace rule {original_path}/{original_filename}-{locale}.{original_extension} in Smartling to give us a file directory that looks like this:
└── docs/
    └── api/
        ├── index.mdx
        ├── index-ja.mdx
        ├── index-ko.mdx
        ├── index-zh.mdx
        └── rs-api/
            ├── index.mdx
            ├── index-ja.mdx
            ├── index-ko.mdx
            ├── index-zh.mdx
            ├── authentication.mdx
            ├── authentication-ja.mdx
            ├── authentication-ko.mdx
            └── authentication-zh.mdx

@bzavhorodskyi
Copy link
Collaborator Author

@bzavhorodskyi I've pushed a commit which would enable us to pick up files without the locale code appended. My thinking is this:

  • The pickup rule is src/content/docs/**/*.mdx
  • The replace rule {original_path}/{original_filename}-{locale}.{original_extension} in Smartling to give us a file directory that looks like this:
└── docs/
    └── api/
        ├── index.mdx
        ├── index-ja.mdx
        ├── index-ko.mdx
        ├── index-zh.mdx
        └── rs-api/
            ├── index.mdx
            ├── index-ja.mdx
            ├── index-ko.mdx
            ├── index-zh.mdx
            ├── authentication.mdx
            ├── authentication-ja.mdx
            ├── authentication-ko.mdx
            └── authentication-zh.mdx

Seems worked as expected

@Sporiff Sporiff force-pushed the feat/THC-900-investigate-smartling-file-paths branch from cb87380 to 4226471 Compare February 19, 2024 23:22
@Sporiff Sporiff merged commit afbde82 into main Feb 20, 2024
8 checks passed
@Sporiff Sporiff deleted the feat/THC-900-investigate-smartling-file-paths branch February 20, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants