Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS purchase verification steps #390

Merged
merged 4 commits into from
Feb 15, 2024
Merged

iOS purchase verification steps #390

merged 4 commits into from
Feb 15, 2024

Conversation

Sporiff
Copy link
Contributor

@Sporiff Sporiff commented Jan 12, 2024

This PR includes a POC change for purchase verification steps in the iOS SDK.

Relates to https://adjustcom.atlassian.net/browse/ADAPP-17342

Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 11:18am

@Sporiff
Copy link
Contributor Author

Sporiff commented Jan 12, 2024

@uerceg as discussed yesterday, this is what I'm imagining the purchase verification steps will look like. Quite simply, we remove content relating to these properties from the article and put everything that is PV-specific in its own section while linking back to the purchase verification article. This article isn't live right now, so the link won't work, but that's the gist of it.

Let me know if you have any feedback or can think of anything else we might need to include. If this is okay, we can go ahead and do the same for the other SDKs.

https://dev-docs-git-purchase-verification-steps-product-content.vercel.app/en/sdk/ios/features/events#purchase-verification

@uerceg
Copy link
Collaborator

uerceg commented Jan 12, 2024

@Sporiff Sounds good to me. One advice might be to move the Purchase Verification chapter below Record event revenue chapter because the verification of the passed revenue sounds like a natural extension of the recording event revenue (so reading those one after another sounds nicer to me).

@Sporiff
Copy link
Contributor Author

Sporiff commented Jan 12, 2024

@uerceg Good shout. Done.

@Sporiff Sporiff force-pushed the purchase-verification-steps branch from c878da3 to fac767d Compare February 15, 2024 11:15
@Sporiff Sporiff merged commit 552330a into main Feb 15, 2024
6 of 7 checks passed
@Sporiff Sporiff deleted the purchase-verification-steps branch February 15, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants