Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Active State Indicator for Navbar #1188

Conversation

112201007
Copy link
Contributor

@112201007 112201007 commented Nov 8, 2024

Fixes #1185

Issues Identification

Self-identified issue: Lack of active state indicator in the navbar, causing confusion regarding the current page.
Closes: #1185

Description

Added Active State Indicator for Navbar to Enhance Navigation with Highlighted Active Links

Summary

This pull request implements an active state indicator for the navbar buttons/links, improving user experience and providing clear visual feedback about the user's current location on the website.

Details

Added CSS classes and JavaScript logic to highlight the currently active navbar link.
When a user navigates to different pages via the navbar, the selected link will be highlighted (either through underlining or changing background color).
This improvement ensures users can easily identify which page they are on, enhancing navigation clarity.

Types of Changes

Please check the boxes that apply

  • Bugfix (non-breaking change that fixes an issue)
  • [ ✅ ] New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Please check the boxes that apply

  • [ ✅ ] My code follows the style guidelines of this project
  • [ ✅ ] I have performed a self-review of my own code
  • [ ✅ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ✅ ] My changes generate no new warnings
  • My changes do not break the current system and pass all existing test cases
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots

If applicable, please attach screenshots of the changes made to the user interface.
Before:
WhatsApp Image 2024-11-08 at 9 11 17 PM
After:
WhatsApp Image 2024-11-09 at 1 18 05 AM
WhatsApp Image 2024-11-09 at 1 18 06 AM

Additional Information

I created an issue for this feature request, but it has not yet been assigned to me. Nonetheless, I have gone ahead and implemented the change and am submitting this pull request. Please consider my contribution accordingly and assign appropriate tags based on the contribution.

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for pathsphere ready!

Name Link
🔨 Latest commit d390b80
🔍 Latest deploy log https://app.netlify.com/sites/pathsphere/deploys/672e6c609f23d10008e64f5d
😎 Deploy Preview https://deploy-preview-1188--pathsphere.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, 112201007, for creating this pull request and contributing to Pathsphere! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@Apoorva57 Apoorva57 merged commit 8ec8bcc into aditya-bhaumik:main Nov 9, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add Active State Indicator for Navbar Links to Enhance User Navigation
2 participants