improved code style #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
helo, thanks for this PR. im gonna accept this PR if the build passes and you kindly can format the commit message to angular format (as are other commits before) : https://github.styleci.io/analyses/prOrAR however since it is not feature or fix or significant refactor - i don't know if it should be #hacktoberfest-accepted though. edit: since you are a first time contributor, as a courtesy i will mark it as #hacktoberfest-accepted :) |
adhocore
reviewed
Oct 3, 2022
|
seems you didnt check https://github.styleci.io/analyses/prOrAR da7158a should be: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improved code style by importing some use statements, substr replacing with strpos