feat: update logging and output functionality #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhizoome
force-pushed
the
jlf/feat-update-logging-and-output-functionality
branch
2 times, most recently
from
c2d3efe to
550e15e
Compare
rhizoome
force-pushed
the
jlf/feat-update-logging-and-output-functionality
branch
from
2c55c29 to
35bf720
Compare
rhizoome
force-pushed
the
jlf/feat-update-logging-and-output-functionality
branch
3 times, most recently
from
7235b6e to
0f729bd
Compare
rhizoome
force-pushed
the
jlf/feat-update-logging-and-output-functionality
branch
2 times, most recently
from
1374c2e to
d755fbc
Compare
rhizoome
force-pushed
the
jlf/feat-update-logging-and-output-functionality
branch
2 times, most recently
from
951a05b to
b366bd6
Compare
winged
approved these changes
Mar 13, 2024
pyaptly/custom_logger.py
Outdated
Comment on lines
30
to
33
| if util.isatty(): | ||
| formats = self.FORMATS_COLOR # pragma: no cover | ||
| else: | ||
| formats = self.FORMATS |
There was a problem hiding this comment.
Could we move this into __init__()? Then you'd only have to make the decision once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple commits not all related to logging and output functionality