Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace check_call with run_command (no-merge) #64

Conversation

rhizoome
Copy link

@rhizoome rhizoome commented Mar 3, 2024

do not merge

@rhizoome rhizoome changed the title refactor: replace check_call with run_command refactor: replace check_call with run_command Mar 3, 2024
@rhizoome rhizoome force-pushed the jlf/chore-replace-check_call-with-run_command branch from a650e9e to 069a920 Compare March 3, 2024 15:58
@rhizoome rhizoome force-pushed the jlf/feat-import-CalledProcessError-for-users-of-run_command branch from 0d13e2a to 3618162 Compare March 3, 2024 15:58
@rhizoome rhizoome requested a review from winged March 3, 2024 15:59
@rhizoome rhizoome changed the title refactor: replace check_call with run_command refactor: replace check_call with run_command (no-merge) Mar 3, 2024
Copy link
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhizoome rhizoome merged commit 479d431 into jlf/feat-import-CalledProcessError-for-users-of-run_command Mar 4, 2024
1 check passed
@rhizoome rhizoome deleted the jlf/chore-replace-check_call-with-run_command branch March 5, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants