Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: ai update conftest.py #100

Closed
wants to merge 1 commit into from
Closed

doc: ai update conftest.py #100

wants to merge 1 commit into from

Conversation

rhizoome
Copy link

No description provided.

@rhizoome rhizoome requested a review from winged March 22, 2024 17:53
Copy link
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some rewriting went the wrong way with code examples. Otherwise LGTM

Comment on lines +97 to +99
```python @pytest.mark.parametrize("freeze", ["2012-10-10 10:10:10"],
indirect=True) def test_snapshot_create_basic(environment, config, freeze):
... ```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```python @pytest.mark.parametrize("freeze", ["2012-10-10 10:10:10"],
indirect=True) def test_snapshot_create_basic(environment, config, freeze):
... ```
```python
@pytest.mark.parametrize("freeze", ["2012-10-10 10:10:10"], indirect=True)
def test_snapshot_create_basic(environment, config, freeze):
...
```


```python
@pytest.mark.parametrize("config", ["mirror-extra.toml"], indirect=True)
def test_mirror_create(environment, config, caplog):
@pytest.mark.parametrize("freeze", ["2012-10-10 10:10:10"], indirect=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@pytest.mark.parametrize("freeze", ["2012-10-10 10:10:10"], indirect=True)
@pytest.mark.parametrize("config", ["mirror-extra.toml"], indirect=True)

@pytest.mark.parametrize("config", ["mirror-extra.toml"], indirect=True)
def test_mirror_create(environment, config, caplog):
@pytest.mark.parametrize("freeze", ["2012-10-10 10:10:10"], indirect=True)
def test_snapshot_create_basic(environment, config, freeze):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def test_snapshot_create_basic(environment, config, freeze):
def test_mirror_create(environment, config, caplog):

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I had to fix that 100 times. And the last time I forgot!

@winged
Copy link
Member

winged commented Jun 11, 2024

If needed we can still look at this. Closing. (JLF)

@winged winged closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants