Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency versions #31

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Update dependency versions #31

merged 2 commits into from
Apr 8, 2024

Conversation

djbower
Copy link
Contributor

@djbower djbower commented Mar 27, 2024

Minimum requirements for pandas 1.3.0.

@djbower
Update dependency versions
c8232aa 
Minimum requirements for pandas 1.3.0.
ZGainsforth
ZGainsforth requested changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@ZGainsforth ZGainsforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versions should also be updated in the readme at the same time. Thanks!

@djbower
Update setup.py
f225f9f 
Update dependencies
@djbower
Copy link
Contributor Author

djbower commented Mar 28, 2024

Both README.rst and setup.py are now consistent in terms of the dependencies.

@djbower
Copy link
Contributor Author

djbower commented Apr 8, 2024 •
edited
Loading

@ZGainsforth Do I need to do anything else or can this pull request now be accepted? Thanks!

@ZGainsforth ZGainsforth merged commit 579d3c4 into adelq:master Apr 8, 2024
0 of 4 checks passed
@ZGainsforth
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZGainsforth ZGainsforth ZGainsforth requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djbower @ZGainsforth