Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract image in textnode #757

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

unsleepy22
Copy link
Contributor

fix the issue that images within text nodes are not extracted, which is not unusual in web pages.
i.e.,

<p><img src="aa.jpg"></img><p>

@unsleepy22 unsleepy22 force-pushed the feat/extract-image-in-textnode branch from 67fa32b to dbdc480 Compare December 2, 2024 08:33
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.26%. Comparing base (4e59c8a) to head (e466953).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #757   +/-   ##
=======================================
  Coverage   99.26%   99.26%           
=======================================
  Files          21       21           
  Lines        3542     3559   +17     
=======================================
+ Hits         3516     3533   +17     
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unsleepy22 unsleepy22 force-pushed the feat/extract-image-in-textnode branch from 1f287dd to 38fa0e6 Compare December 2, 2024 12:52
trafilatura/utils.py Outdated Show resolved Hide resolved
trafilatura/htmlprocessing.py Outdated Show resolved Hide resolved
@adbar
Copy link
Owner

adbar commented Dec 2, 2024

Hi @unsleepy22, thanks for the PR. I still have questions about it (see above), could you please have a look?

@unsleepy22 unsleepy22 force-pushed the feat/extract-image-in-textnode branch from 38fa0e6 to cbd4132 Compare December 3, 2024 02:06
@unsleepy22 unsleepy22 force-pushed the feat/extract-image-in-textnode branch from cbd4132 to e466953 Compare December 3, 2024 02:17
@unsleepy22
Copy link
Contributor Author

Hi @unsleepy22, thanks for the PR. I still have questions about it (see above), could you please have a look?

thanks for your comments, fixed and rebased my commits, would you take a look again?

@adbar
Copy link
Owner

adbar commented Dec 3, 2024

LGTM, thanks.

@adbar adbar merged commit b7bfcc3 into adbar:master Dec 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants