-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract image in textnode #757
Conversation
67fa32b
to
dbdc480
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #757 +/- ##
=======================================
Coverage 99.26% 99.26%
=======================================
Files 21 21
Lines 3542 3559 +17
=======================================
+ Hits 3516 3533 +17
Misses 26 26 ☔ View full report in Codecov by Sentry. |
1f287dd
to
38fa0e6
Compare
Hi @unsleepy22, thanks for the PR. I still have questions about it (see above), could you please have a look? |
38fa0e6
to
cbd4132
Compare
cbd4132
to
e466953
Compare
thanks for your comments, fixed and rebased my commits, would you take a look again? |
LGTM, thanks. |
fix the issue that images within text nodes are not extracted, which is not unusual in web pages.
i.e.,