Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs: theme, text embeddings, used-by #447

Merged
merged 9 commits into from
Nov 28, 2023
Merged

Conversation

tonyyanga
Copy link
Contributor

Epsilla has a new cloud offering with a free tier. This PR mentions the cloud offering as an alternative way to running a docker container locally, which can be a big ask for some users.

A few other changes are explained in-line.

To see the updated version: https://trafilatura-epsilla.readthedocs.io/en/latest/tutorial-epsilla.html

@tonyyanga
Copy link
Contributor Author

I have no idea why the CI tests are failing. They seem to suggest there are issues with the test_dates test case. It seems unrelated to the documentation updates.

@tonyyanga
Copy link
Contributor Author

@adbar

Looks like when htmldate is updated to 1.6.0, there are some behavior changes that impacted trafilatura tests. In this PR, I have bumped the required version for htmldate and updated the test cases for the new behavior.

See this colab notebook that demonstrates the changes in behavior: https://colab.research.google.com/drive/1UHiBcDlWt15qYlMZ6UKZG5ANs7ZRP0A0?usp=sharing

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f66414) 96.90% compared to head (1c9a1b8) 96.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #447   +/-   ##
=======================================
  Coverage   96.90%   96.90%           
=======================================
  Files          22       22           
  Lines        3363     3363           
=======================================
  Hits         3259     3259           
  Misses        104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/tutorial-epsilla.rst Outdated Show resolved Hide resolved
docs/tutorial-epsilla.rst Outdated Show resolved Hide resolved
@adbar
Copy link
Owner

adbar commented Nov 27, 2023

Hi @tonyyanga, thanks for the changes, my remarks are above.

The change in htmldate is also tackled in #444 but I haven't merged it yet.

@tonyyanga
Copy link
Contributor Author

Thanks for calling out the typos! Pushed a change to fix them.

@adbar adbar changed the title Update text embedding tutorial to explain the Epsilla cloud option update docs: setup, text embeddings, used-by Nov 28, 2023
@adbar adbar changed the title update docs: setup, text embeddings, used-by update docs: theme, text embeddings, used-by Nov 28, 2023
@adbar adbar merged commit e7b5723 into adbar:master Nov 28, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants