-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docs: theme, text embeddings, used-by #447
Conversation
I have no idea why the CI tests are failing. They seem to suggest there are issues with the |
Looks like when htmldate is updated to 1.6.0, there are some behavior changes that impacted trafilatura tests. In this PR, I have bumped the required version for htmldate and updated the test cases for the new behavior. See this colab notebook that demonstrates the changes in behavior: https://colab.research.google.com/drive/1UHiBcDlWt15qYlMZ6UKZG5ANs7ZRP0A0?usp=sharing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #447 +/- ##
=======================================
Coverage 96.90% 96.90%
=======================================
Files 22 22
Lines 3363 3363
=======================================
Hits 3259 3259
Misses 104 104 ☔ View full report in Codecov by Sentry. |
Hi @tonyyanga, thanks for the changes, my remarks are above. The change in htmldate is also tackled in #444 but I haven't merged it yet. |
Thanks for calling out the typos! Pushed a change to fix them. |
Epsilla has a new cloud offering with a free tier. This PR mentions the cloud offering as an alternative way to running a docker container locally, which can be a big ask for some users.
A few other changes are explained in-line.
To see the updated version: https://trafilatura-epsilla.readthedocs.io/en/latest/tutorial-epsilla.html