Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config option: external URLs for feeds and sitemaps #441

Merged
merged 3 commits into from
Nov 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion trafilatura/cli_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -236,10 +236,11 @@ def cli_discovery(args):
input_urls = url_store.dump_urls()
if args.list:
url_store.reset()
ext = use_config(filename=args.config_file).getboolean('DEFAULT', 'EXTERNAL_URLS')

# link discovery and storage
with ThreadPoolExecutor(max_workers=args.parallel) as executor:
futures = (executor.submit(func, url, target_lang=args.target_language) for url in input_urls)
futures = (executor.submit(func, url, target_lang=args.target_language, external=ext) for url in input_urls)
# process results from the parallel threads and add them
# to the compressed URL dictionary for further processing
for future in as_completed(futures):
Expand Down
20 changes: 11 additions & 9 deletions trafilatura/feeds.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
BLACKLIST = re.compile(r'\bcomments\b') # no comment feed


def handle_link_list(linklist, domainname, baseurl, target_lang=None):
def handle_link_list(linklist, domainname, baseurl, target_lang=None, external=False):
'''Examine links to determine if they are valid and
lead to a web page'''
output_links = []
Expand All @@ -38,7 +38,7 @@ def handle_link_list(linklist, domainname, baseurl, target_lang=None):
# control output for validity
checked = check_url(link, language=target_lang)
if checked is not None:
if not is_similar_domain(domainname, checked[1]) and not "feed" in link:
if not external and not "feed" in link and not is_similar_domain(domainname, checked[1]):
LOGGER.warning('Rejected, diverging domain names: %s %s', domainname, checked[1])
else:
output_links.append(checked[0])
Expand All @@ -48,7 +48,7 @@ def handle_link_list(linklist, domainname, baseurl, target_lang=None):
return output_links


def extract_links(feed_string, domainname, baseurl, reference, target_lang=None):
def extract_links(feed_string, domainname, baseurl, reference, target_lang=None, external=False):
'''Extract links from Atom and RSS feeds'''
feed_links = []
# check if it's a feed
Expand Down Expand Up @@ -91,7 +91,7 @@ def extract_links(feed_string, domainname, baseurl, reference, target_lang=None)
)

# refine
output_links = handle_link_list(feed_links, domainname, baseurl, target_lang)
output_links = handle_link_list(feed_links, domainname, baseurl, target_lang, external)
output_links = [l for l in output_links if l != reference and l.count('/') > 2]
# log result
if feed_links:
Expand Down Expand Up @@ -145,14 +145,16 @@ def determine_feed(htmlstring, baseurl, reference):
return output_urls


def find_feed_urls(url, target_lang=None):
def find_feed_urls(url, target_lang=None, external=False):
"""Try to find feed URLs.

Args:
url: Webpage or feed URL as string.
Triggers URL-based filter if the webpage isn't a homepage.
target_lang: Define a language to filter URLs based on heuristics
(two-letter string, ISO 639-1 format).
(two-letter string, ISO 639-1 format).
external: Similar hosts only or external URLs
(boolean, defaults to False).

Returns:
The extracted links as a list (sorted list of unique links).
Expand All @@ -166,12 +168,12 @@ def find_feed_urls(url, target_lang=None):
downloaded = fetch_url(url)
if downloaded is not None:
# assume it's a feed
feed_links = extract_links(downloaded, domainname, baseurl, url, target_lang)
feed_links = extract_links(downloaded, domainname, baseurl, url, target_lang, external)
if len(feed_links) == 0:
# assume it's a web page
for feed in determine_feed(downloaded, baseurl, url):
feed_string = fetch_url(feed)
feed_links.extend(extract_links(feed_string, domainname, baseurl, url, target_lang))
feed_links.extend(extract_links(feed_string, domainname, baseurl, url, target_lang, external))
# filter triggered, prepare it
if len(url) > len(baseurl) + 2:
urlfilter = url
Expand All @@ -191,7 +193,7 @@ def find_feed_urls(url, target_lang=None):
f'https://news.google.com/rss/search?q=site:{baseurl}&hl={target_lang}&scoring=n&num=100'
)
if downloaded is not None:
feed_links = extract_links(downloaded, domainname, baseurl, url, target_lang)
feed_links = extract_links(downloaded, domainname, baseurl, url, target_lang, external)
feed_links = filter_urls(feed_links, urlfilter)
LOGGER.debug('%s Google news links found for %s', len(feed_links), domainname)
return feed_links
Expand Down
3 changes: 3 additions & 0 deletions trafilatura/settings.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,6 @@ MAX_REPETITIONS = 2

# Extraction option for Htmldate
EXTENSIVE_DATE_SEARCH = on

# URLs in feeds and sitemaps
EXTERNAL_URLS = off
Loading
Loading