Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Function to populate cypress test spec if no argument value passed [3595] #3596

Merged
merged 10 commits into from
Oct 1, 2024
Merged

Update: Function to populate cypress test spec if no argument value passed [3595] #3596

merged 10 commits into from
Oct 1, 2024

Conversation

cahirodoherty-learningpool
Copy link
Contributor

@cahirodoherty-learningpool cahirodoherty-learningpool commented Sep 9, 2024 •
edited
Loading

Addresses #3595

Update

  • Function to populate cypress test spec if no argument value passed

@cahirodoherty-learningpool cahirodoherty-learningpool changed the title Issue/3595 Update: Function to populate cypress test spec if no argument value passed [3595] Sep 9, 2024
@cahirodoherty-learningpool cahirodoherty-learningpool marked this pull request as ready for review September 9, 2024 14:00
@oliverfoster
Copy link
Member

Are you doing the jest equivalent in another pr?

oliverfoster
oliverfoster reviewed Sep 10, 2024
View reviewed changes
test.js Outdated Show resolved Hide resolved
@cahirodoherty-learningpool
Copy link
Contributor Author

Are you doing the jest equivalent in another pr?

Hi @oliverfoster ,
Sorry, I somehow overlooked this comment but I have actioned now 👍

@oliverfoster oliverfoster merged commit 642800b into master Oct 1, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/3595 branch October 1, 2024 18:12
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
@semantic-release-bot
Chore(release): 5.41.0 [skip ci]
dba8e70 
# [5.41.0](v5.40.15...v5.41.0) (2024-10-01)

### Update

* Populate test spec from config.json:build.includes where required [3595] (#3596) ([642800b](642800b)), closes [#3596](#3596)
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

🎉 This PR is included in version 5.41.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmyadams lemmyadams lemmyadams approved these changes

@ethan-lp ethan-lp ethan-lp approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@joe-allen-89 joe-allen-89 Awaiting requested review from joe-allen-89

Assignees

@cahirodoherty-learningpool cahirodoherty-learningpool

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cahirodoherty-learningpool @oliverfoster @ethan-lp @lemmyadams