Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Allow showing number and visited checkmark when using pin images (fix #537) #538

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Update: Allow showing number and visited checkmark when using pin images (fix #537) #538

merged 1 commit into from
Jan 9, 2025

Conversation

swashbuck
Copy link
Contributor

Fix #537

Update

  • Allows number to be shown when using pin images
  • Show visited checkmark when using pin images

Testing

Test alongside adaptlearning/adapt-contrib-hotgraphic#338

Dependencies

adaptlearning/adapt-contrib-hotgraphic#338

@swashbuck swashbuck self-assigned this Dec 17, 2024
@swashbuck swashbuck mentioned this pull request Dec 17, 2024
Open
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

guywillis
guywillis approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

@oliverfoster oliverfoster merged commit ac5cd5f into master Jan 9, 2025
1 check passed
@oliverfoster oliverfoster deleted the issue/537 branch January 9, 2025 14:12
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
@semantic-release-bot
Chore(release): 9.24.0 [skip ci]
3c5d654 
# [9.24.0](v9.23.1...v9.24.0) (2025-01-09)

### Update

* Show number and visited checkmark when using pin images for Hot Graphic #338 (#538) ([ac5cd5f](ac5cd5f)), closes [#338](#338) [#538](#538)
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

🎉 This PR is included in version 9.24.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@guywillis guywillis guywillis approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@swashbuck swashbuck

Labels
enhancement released
Projects
adapt_framework: The TODO Board
Status: Recently Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Hot Graphic styles to support numbered pins when using image pins
4 participants
@swashbuck @oliverfoster @guywillis @cahirodoherty-learningpool