Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Allow numbered pins when using graphic pins, show visited icon (fix #337 #324) #338

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Dec 17, 2024

Fix #337 #324

Update

  • Allow numbered pins when using graphic pins
  • Show visited checkmark icon when using graphic pins

Testing

With numbering:

  1. In a Hot Graphic, set _useNumberedPins to true.
  2. Add pin images for each item with _pin.src
  3. _useGraphicsAsPins should be set to false
  4. The numbering icon should appear before visiting. After visiting, the checkmark icon should appear.

Without numbering:

  1. In a Hot Graphic, add pin images for each item with _pin.src
  2. _useGraphicsAsPins should be set to false
  3. No icon should show until the item is visited. After that, the checkmark icon should appear

Dependencies

adaptlearning/adapt-contrib-vanilla#538

Screenshots

@swashbuck swashbuck changed the title Update: Allow numbered pins when using graphic pins (fix #337) Update: Allow numbered pins when using graphic pins, show visited icon (fix #337 #324) Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Allow numbered pins when using graphics as pins
1 participant