Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Added support for _canShowCorrectness #213

Merged
merged 8 commits into from
Oct 28, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ guide the learner’s interaction with the component.

**\_canShowModelAnswer** (boolean): Setting this to `false` prevents the [**_showCorrectAnswer** button](https://github.com/adaptlearning/adapt_framework/wiki/Core-Buttons) from being displayed. The default is `true`.

**\_canShowCorrectness** (boolean): Setting this to `true` replaces the associated `_canShowModelAnswer` toggle button and displays correctness directly on the component. The default is `false`.

**\_canShowFeedback** (boolean): Setting this to `false` disables feedback, so it is not shown to the user. The default is `true`.

**\_canShowMarking** (boolean): Setting this to `false` prevents ticks and crosses being displayed on question completion. The default is `true`.
Expand Down
1 change: 1 addition & 0 deletions example.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"_shouldDisplayAttempts": false,
"_questionWeight": 1,
"_canShowModelAnswer": true,
"_canShowCorrectness": false,
"_canShowFeedback": true,
"_canShowMarking": true,
"_recordInteraction": true,
Expand Down
34 changes: 34 additions & 0 deletions less/slider.less
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,40 @@
}
}

// Correctness state
&__state {
position: relative;
min-height: 1.5rem;
// Indent half the width of the range slider handle either side
margin-left: @slider-handle-width / 2;
margin-right: @slider-handle-width / 2;

.dir-rtl & {
.transform(rotateY(180deg));
}
}

&__icon {
display: flex;
justify-content: center;
align-items: center;
position: absolute;
top: 0;
.transform(translateX(-50%));

.dir-rtl & {
.transform(translateX(-50%) rotateY(180deg));
}
}

&__correct-icon .icon {
.icon-tick;
}

&__incorrect-icon .icon {
.icon-cross;
}

// Scale
&__scale-container {
position: relative;
Expand Down
9 changes: 9 additions & 0 deletions properties.schema
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,15 @@
"validators": [],
"help": "Allow the user to view the 'model answer' if they answer the question incorrectly?"
},
"_canShowCorrectness": {
"type": "boolean",
"required": false,
"default": false,
"title": "Display correctness",
"inputType": "Checkbox",
"validators": [],
"help": "If enabled, this replaces the associated 'model answer' toggle button and displays correctness directly on the component."
},
"_canShowFeedback": {
"type": "boolean",
"required": true,
Expand Down
6 changes: 6 additions & 0 deletions schema/component.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,12 @@
"description": "Allow the user to view the 'model answer' if they answer the question incorrectly",
"default": true
},
"_canShowCorrectness": {
"type": "boolean",
"title": "Enable to display correctness",
"description": "If enabled, this replaces the associated 'model answer' toggle button and displays correctness directly on the component",
"default": false
},
"_canShowFeedback": {
"type": "boolean",
"title": "Enable feedback",
Expand Down
36 changes: 33 additions & 3 deletions templates/slider.jsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import Adapt from 'core/js/adapt';
import React, { useRef } from 'react';
import { classes, templates } from 'core/js/reactHelpers';

Expand All @@ -6,6 +7,8 @@ export default function Slider (props) {
_id,
_globals,
_shouldShowMarking,
_canShowModelAnswer,
_canShowCorrectness,
_isInteractionComplete,
_isCorrectAnswerShown,
_isEnabled,
Expand Down Expand Up @@ -49,6 +52,8 @@ export default function Slider (props) {
const selectedIndex = getIndexFromValue(selectedValue);
const selectedWidth = calculatePercentFromIndex(selectedIndex);

const ariaLabels = Adapt.course.get('_globals')._accessibility._ariaLabels;

return (
<div className="component__inner slider__inner">

Expand All @@ -58,7 +63,10 @@ export default function Slider (props) {
className={classes([
'component__widget slider__widget',
!_isEnabled && 'is-disabled',
_isInteractionComplete && 'is-complete is-submitted show-user-answer',
_isInteractionComplete && 'is-complete is-submitted',
_isInteractionComplete && !_canShowCorrectness && !_isCorrectAnswerShown && 'show-user-answer',
_isInteractionComplete && _canShowModelAnswer && _isCorrectAnswerShown && 'show-correct-answer',
_isInteractionComplete && _canShowCorrectness && 'show-correctness',
_shouldShowMarking && _isCorrect && 'is-correct',
_shouldShowMarking && !_isCorrect && 'is-incorrect'
])}
Expand Down Expand Up @@ -101,11 +109,14 @@ export default function Slider (props) {
key={index}
className="slider__number js-slider-number js-slider-number-click"
data-id={value}
aria-hidden="true"
aria-disabled= {_isInteractionComplete || null}
style={{ left: `${calculatePercentFromIndex(index)}%` }}
onClick={e => onNumberSelected(parseFloat(e.currentTarget.getAttribute('data-id')))}
>
{scaleStepPrefix}{value}{scaleStepSuffix}
{_shouldShowMarking && _isInteractionComplete &&
<span className="aria-label">{`${_isCorrect ? ariaLabels.correct : ariaLabels.incorrect}, ${selectedValue === value ? ariaLabels.selectedAnswer : ariaLabels.unselectedAnswer}. ${scaleStepPrefix}${value}${scaleStepSuffix}`}</span>
oliverfoster marked this conversation as resolved.
Show resolved Hide resolved
}
<span aria-hidden="true">{scaleStepPrefix}{value}{scaleStepSuffix}</span>
</div>
);
})
Expand Down Expand Up @@ -147,6 +158,25 @@ export default function Slider (props) {
}
</div>

{/* annotate the answer range correctness */}
{_canShowCorrectness &&
<div className="slider__state" aria-hidden="true">
{_items.slice(0).map((item, index) =>
<div
className={classes([
'slider__icon',
_isInteractionComplete && item.correct && 'slider__correct-icon',
_isInteractionComplete && !item.correct && 'slider__incorrect-icon'
])}
style={{ left: `${calculatePercentFromIndex(index)}%` }}
key={item.value}
>
<span className='icon'></span>
</div>
)}
</div>
}

{/* always present start and end notches */}
<div className="slider__scale-container js-slider-scale">
<div className="slider__scale-notch slider__scale-notch-start" />
Expand Down