Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: missing attribute values causing runtime error #205

Merged
merged 3 commits into from
May 29, 2024
Merged

Fix: missing attribute values causing runtime error #205

merged 3 commits into from
May 29, 2024

Conversation

danielghost
Copy link
Contributor

@danielghost danielghost commented May 21, 2024 •
edited
Loading

Fixes #204.

Fix

  • Added default attribute values for _scaleStart, _scaleEnd and _scaleStep.
  • Restrict _scaleStep to a positive number.

Update

  • Changed _scaleEnd schema default from 1 to 10.

@danielghost
Fix: added default attribute values for _scaleStart, _scaleEnd an…
0230587 
…d `_scaleStep`. Changed `_scaleEnd` schema default from 1 to 10. (fixes #204).
@danielghost danielghost self-assigned this May 21, 2024
oliverfoster
oliverfoster reviewed May 21, 2024
View reviewed changes
Copy link
Member

@oliverfoster oliverfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will _scaleStep set to 0 work?

@danielghost
Copy link
Contributor Author

Will _scaleStep set to 0 work?

Good catch, this will need safeguarding against due to bee1e3b. Also need to restrict this to positive numbers only.

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes May 22, 2024
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@danielghost danielghost requested a review from oliverfoster May 22, 2024 17:01
guywillis
guywillis approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@joe-allen-89 joe-allen-89 merged commit a85cdaf into master May 29, 2024
github-actions bot pushed a commit that referenced this pull request May 29, 2024
@semantic-release-bot
Chore(release): 4.5.2 [skip ci]
8d08c1e 
## [4.5.2](v4.5.1...v4.5.2) (2024-05-29)

### Chore

* e2e tests on slider component (Issue/201) (#202) ([4e21470](4e21470)), closes [#202](#202)

### Fix

* missing attribute values causing runtime error (#205) ([a85cdaf](a85cdaf)), closes [#205](#205) [#204](#204)
@joe-allen-89 joe-allen-89 deleted the issue/204 branch May 29, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@guywillis guywillis guywillis approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@danielghost danielghost

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing default attribute values can cause range input display issues or runtime errors
5 participants
@danielghost @oliverfoster @guywillis @cahirodoherty-learningpool @joe-allen-89