Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: e2e tests on slider component (Issue/201) #202

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Chore: e2e tests on slider component (Issue/201) #202

merged 4 commits into from
Apr 11, 2024

Conversation

lemmyadams
Copy link
Contributor

Addresses #201

@lemmyadams lemmyadams self-assigned this Mar 26, 2024
@lemmyadams
Copy link
Contributor Author

Relies on adaptlearning/adapt_framework#3533

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Mar 28, 2024
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

oliverfoster
oliverfoster requested changes Apr 8, 2024
View reviewed changes
test/e2e/slider.cy.js Outdated Show resolved Hide resolved
@oliverfoster oliverfoster merged commit 4e21470 into master Apr 11, 2024
@oliverfoster oliverfoster deleted the issue/201 branch April 11, 2024 13:40
github-actions bot pushed a commit that referenced this pull request May 29, 2024
@semantic-release-bot
Chore(release): 4.5.2 [skip ci]
8d08c1e 
## [4.5.2](v4.5.1...v4.5.2) (2024-05-29)

### Chore

* e2e tests on slider component (Issue/201) (#202) ([4e21470](4e21470)), closes [#202](#202)

### Fix

* missing attribute values causing runtime error (#205) ([a85cdaf](a85cdaf)), closes [#205](#205) [#204](#204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethan-lp ethan-lp ethan-lp approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@lemmyadams lemmyadams

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lemmyadams @oliverfoster @cahirodoherty-learningpool @ethan-lp