Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Remove ariaQuestion placeholder text (fixes #196) #197

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Update: Remove ariaQuestion placeholder text (fixes #196) #197

merged 1 commit into from
Nov 22, 2023

Conversation

kirsty-hames
Copy link
Contributor

@kirsty-hames kirsty-hames commented Nov 20, 2023 •
edited
Loading

Prevent placeholder text being copied over and left in accessible courses. Property description is noted in README and schema help/description for reference.

Fixes #196

Missing ariaQuestion property added to wiki.

Note, ariaScaleName also contains placeholder text however I decided to leave this as is. ariaScaleName is a required property but because the value is content specific there isn't an appropriate default to set so placeholder text makes sense here.

@kirsty-hames kirsty-hames self-assigned this Nov 20, 2023
guywillis
guywillis approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Nov 22, 2023
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@kirsty-hames kirsty-hames merged commit 832bd98 into master Nov 22, 2023
1 check passed
@kirsty-hames kirsty-hames deleted the issue/196 branch November 22, 2023 17:24
github-actions bot pushed a commit that referenced this pull request Nov 22, 2023
@semantic-release-bot
Chore(release): 4.5.0 [skip ci]
288880d 
# [4.5.0](v4.4.0...v4.5.0) (2023-11-22)

### Update

* remove ariaQuestion placeholder text (fixes #196) #197 ([832bd98](832bd98)), closes [#196](#196) [#197](#197)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 4.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@guywillis guywillis guywillis approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
accessibility released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove ariaQuestion placeholder text
4 participants
@kirsty-hames @oliverfoster @guywillis @cahirodoherty-learningpool