Update: Move notify title above body text (fix #586) (#587)

adaptlearning · Oct 15, 2024 · 8557584 · 8557584
1 parent babfed2
commit 8557584
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 16 deletions.
diff --git a/less/core/notify.less b/less/core/notify.less
@@ -42,7 +42,7 @@
         flex-direction: row;
         column-gap: 1rem;
 
-        .notify__body {
+        .notify__text {
           width: 60%;
         }
 

diff --git a/templates/notifyPopup.hbs b/templates/notifyPopup.hbs
@@ -13,15 +13,6 @@
         </div>
         {{/if}}
 
-        {{#if title}}
-        <div class="notify__title{{#if isAltTitle}} aria-label{{/if}}" id="notify-heading">
-          <div class="notify__title-inner" role="heading" aria-level="{{a11y_aria_level _id 'notify' _ariaLevel}}">
-            {{{compile title}}}
-          </div>
-        </div>
-        {{/if}}
-
-        {{#any _graphic._src body}}
         <div class="notify__section">
           <div class="notify__section-inner">
 
@@ -40,13 +31,23 @@
             {{~/any~}}
             {{~/if~}}
 
-            {{~#if body~}}
-            <div class="notify__body">
-              <div class="notify__body-inner">
-                {{{compile body}}}
+            <div class="notify__text">
+              {{#if title}}
+              <div class="notify__title{{#if isAltTitle}} aria-label{{/if}}" id="notify-heading">
+                <div class="notify__title-inner" role="heading" aria-level="{{a11y_aria_level _id 'notify' _ariaLevel}}">
+                  {{{compile title}}}
+                </div>
+              </div>
+              {{/if}}
+
+              {{~#if body~}}
+              <div class="notify__body">
+                <div class="notify__body-inner">
+                  {{{compile body}}}
+                </div>
               </div>
+              {{~/if~}}
             </div>
-            {{~/if~}}
 
             {{~#if _graphic._src~}}
             {{~#any (equals _imageAlignment 'right') (equals _imageAlignment 'bottom')~}}
@@ -65,7 +66,6 @@
 
           </div>
         </div>
-        {{/any}}
 
         {{#equals _type "alert"}}
         <div class="notify__btn-container">