Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: linkedModel values not correctly setup on scale when inherited #111

Merged
merged 2 commits into from
May 30, 2024
Merged

Fix: linkedModel values not correctly setup on scale when inherited #111

merged 2 commits into from
May 30, 2024

Conversation

danielghost
Copy link
Contributor

@danielghost danielghost commented May 21, 2024 •
edited
Loading

Fixes #110.

Fix

  • Amended execution order so _setupLinkedModel is called before setupModelItems so model values inherited from linkedModel are already set in order for _items to be correctly configured.
  • Restrict _scaleStep to a positive number.

Update

  • Changed _scaleEnd schema default from 1 to 10.

@danielghost danielghost self-assigned this May 21, 2024
oliverfoster
oliverfoster requested changes May 21, 2024
View reviewed changes
js/ConfidenceSliderModel.js Outdated Show resolved Hide resolved
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected thanks. Testing on Mac Safari, Chrome, FF and iPhone.

@kirsty-hames kirsty-hames merged commit 2db8a0e into master May 30, 2024
@kirsty-hames kirsty-hames deleted the issue/110 branch May 30, 2024 11:47
github-actions bot pushed a commit that referenced this pull request May 30, 2024
@semantic-release-bot
Chore(release): 5.5.2 [skip ci]
7ee1dd8 
## [5.5.2](v5.5.1...v5.5.2) (2024-05-30)

### Fix

* `linkedModel` values not correctly setup on scale when inherited (#111) ([2db8a0e](2db8a0e)), closes [#111](#111) [#110](#110)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.5.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@danielghost danielghost

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_linkedId model values not correctly setup on scale
4 participants
@danielghost @kirsty-hames @oliverfoster @cahirodoherty-learningpool