Optimizations to className() and events()

adaptlearning · Apr 9, 2024 · 426b8c1 · 426b8c1
1 parent 732e195
commit 426b8c1
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/js/BoxMenuItemView.js b/js/BoxMenuItemView.js
@@ -5,20 +5,23 @@ import router from 'core/js/router';
 class BoxMenuItemView extends MenuItemView {
 
   className() {
-    const entireItemClickable = this.areEntireItemsClickable() ? 'is-entire-item-clickable' : '';
-    return `${super.className()} boxmenu-item ${entireItemClickable}`;
+    let classes = `${super.className()} boxmenu-item`;
+    if (this.areEntireItemsClickable()) {
+      classes += ' is-entire-item-clickable';
+    }
+    return classes;
   }
 
   events() {
     if (this.areEntireItemsClickable()) {
       return {
         click: 'onClickMenuItemButton'
       };
-    } else {
-      return {
-        'click .js-btn-click': 'onClickMenuItemButton'
-      };
     }
+
+    return {
+      'click .js-btn-click': 'onClickMenuItemButton'
+    };
   }
 
   attributes() {