Fix: Exclude hidden items from items count ARIA (fixes #164) (#170)

* Fix: Exclude hidden items from items count ARIA * Fix: BoxMenuGroupView updated to exclude hidden children.
adaptlearning · Oct 30, 2023 · 2a09783 · 2a09783
1 parent 0ac6fe6
commit 2a09783
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/js/BoxMenuGroupView.js b/js/BoxMenuGroupView.js
@@ -15,7 +15,9 @@ class BoxMenuGroupView extends MenuItemView {
   }
 
   updateItemCount() {
-    const models = this.model.getChildren().models;
+    const models = this.model.getChildren().where({
+      _isHidden: false
+    });
     const totalChildren = models.length;
     models.forEach(model => model.set('_totalChild', totalChildren));
   }

diff --git a/js/BoxMenuView.js b/js/BoxMenuView.js
@@ -23,6 +23,10 @@ class BoxMenuView extends MenuView {
   addChildren() {
     let nthChild = 0;
     const models = this.model.getChildren().models;
+    const totalChild = this.model.getChildren().where({
+      _isHidden: false
+    }).length;
+
     const childViews = [];
     models.forEach(model => {
       if (!model.get('_isAvailable')) return;
@@ -35,7 +39,7 @@ class BoxMenuView extends MenuView {
       nthChild++;
       model.set({
         _nthChild: nthChild,
-        _totalChild: models.length
+        _totalChild: totalChild
       });
 
       const ChildView = (model.get('_type') === 'menu' && model.get('_boxMenu') && model.get('_boxMenu')._renderAsGroup) ?