Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: run update on course data with original data to load course.json extension settings (fixes #53) #54

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

joe-allen-89
Copy link
Contributor

info: replaced promise all with simple await function for course data only, I don't think there's a need to run update on config from testing as all data is already present.

#53

Fix

@joe-allen-89 joe-allen-89 added the bug An error has occurred label Sep 5, 2024
@joe-allen-89 joe-allen-89 self-assigned this Sep 5, 2024
@joe-allen-89 joe-allen-89 linked an issue Sep 5, 2024 that may be closed by this pull request
@taylortom taylortom merged commit ee10920 into master Sep 9, 2024
2 checks passed
@taylortom taylortom deleted the issue/53 branch September 9, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error has occurred
Projects
Development

Successfully merging this pull request may close these issues.

Custom theme property values are not imported
2 participants