Fix parsing locale from context #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unconfident
commented
Nov 6, 2020
| @@ -4,6 +4,21 @@ const chalk = require('chalk'); | |||
| const get = require('lodash.get'); | |||
| const templite = require('templite'); | |||
|
|
|||
| // should match "/en/", "/en-US/", "/en_US/" | |||
| const contextLocaleRegex = /^\/([a-z]{2,}(?:[_-][a-z]{2,})?)\//i; | |||
There was a problem hiding this comment.
Maybe maximum length for a segment should be limited to 2 exactly but there's a chance that somebody uses "eng" or "english" as their locale name so I left it as [...]{2,}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4 by parsing context locale from
page.filePathSteminstead ofpage.url.This should be considered a breaking change, especially because of regexp.
Also because filePathStem is used required minimum supported 11ty version is 0.9.0+Nvm, it's already described in peerDependencies as^0.11.0so nothing changes here