-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust migration PoC #35
Open
gboutry
wants to merge
11
commits into
adaltas:master
Choose a base branch
from
gboutry:rust-migration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: update windows10 vm
Installing a system dependency is out of scope for this script, therefore krb5 will be vendored
gboutry
force-pushed
the
rust-migration
branch
from
January 22, 2023 12:00
038c6e4
to
b5d24eb
Compare
PaulFarault
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PACordonnier
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is PoC showing what a rust migration could look like.
There should be no change to the interface.
What's new in this PR:
Requirements change
The dependencies change, node-gyp is no longer required for the build, such as python (but python is still needed for
src/server.py
How to build
In any case, the build command is:
npm install
, but os and installation method may vary:export KRB5_HOME=/path/to/your/prefix
orexport PKG_CONFIG_PATH=/path/to/your/krb5/pkg-config
export KRB5_HOME=/path/to/your/homebrew/cellar/krb5
(this is a custom prefix) orexport PKG_CONFIG_PATH=/path/to/your/homebrew/cellar/krb5/lib/pkg-config
$env:KRB5_HOME=X:\path\to\you\mit\kerberos\installation
New
install_krb5.sh
now installs MIT Kerberos into a foldervendor
at the root of the project. If you want to build the project with this version, simply set the variableexport KRB5_HOME=${project_path}/vendor
.npm run local_test
, it will instantiate a KDC, a Kadmind and a server.py on your host, without docker. You must have the krb5 sbin binaries in your path. If you don't overwrite your PATH variables and you don't have system-wide binaries, you can set the variableexport KRB5_HOME=/path/to/your/krb5/prefix
ubuntu-vendored
, it's the same as ubuntu but instead of getting krb5 from apt, it's using theinstall_krb5.sh
scriptBreaking Change
This PR has been tested on Ubuntu 20.04, MacOs 11 Big Sur, Windows 10 20H2, and with the containers.
All tests have been performed on a x86_64 processor, would be interested with feedback on ARM (macos).