Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device_info.py: Fix use of Iterable #204

Merged
merged 1 commit into from
Oct 19, 2024
Merged

device_info.py: Fix use of Iterable #204

merged 1 commit into from
Oct 19, 2024

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Oct 18, 2024

#202 made device_info.py not importable in CircuitPython.

Iterable is used only for type-checking. Use from typing instead of importing from collections.abc.

@ktnyt FYI

Iterable is used only for type-checking. Use `from typing` instead of importing from `collections.abc`
@dhalbert
Copy link
Collaborator Author

I'm merging this without a review because the current main is broken.

@dhalbert dhalbert merged commit 313e7cd into main Oct 19, 2024
2 checks passed
@dhalbert dhalbert deleted the dhalbert-patch-1 branch October 19, 2024 23:49
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 22, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 10.0.9 from 10.0.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#203 from dhalbert/nus-buffers-at-least-mtu
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#206 from dhalbert/pnp_id-defaults
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#204 from adafruit/dhalbert-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#202 from ktnyt/device-info-pnp-id

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_USB_Host_Mass_Storage, Adafruit_CircuitPython_USB_Host_MIDI

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants