Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/optimize layout using articulation points #719

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from

Conversation

johannesdeselaers
Copy link
Contributor

should be merged after #691

checks of second checkmark of #431 , thus closes #431

please tell me if you think the relayout runtime is acceptable, or whether this still needs optimization

I did not take the (debug) coloring of the articulation points out for the moment, so you can see what's going on (blue = insignificant articulation point, green = significant articulation point that should be fixed). This should be done before merging this pull request.

@AtiX
Copy link
Contributor

AtiX commented Jul 8, 2015

Relayouting speed (after releasing the brush) is fine for me.
But:

  • Overall interaction is slower and more laggy, the brush is not as responsive as on brickify.it. how can this be?
  • It seems like this algorithm produces much more plates and less lego bricks?

@johannesdeselaers
Copy link
Contributor Author

hmm, about the laggy interaction: no idea
I don't remember touching any brush/interaction/rendering code (except for the brick colors)
I will check.

As for the increased number of plates: that is expected.
Plates are far more stable & connected, so when the algorithm tries to remedy unconnected components or weak articulation points, it currently only uses plates to relayout. I tried using both bricks and plates, but that did not work out well.

@AtiX
Copy link
Contributor

AtiX commented Jul 12, 2015

Any updates on the slower interaction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize stability
3 participants