-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streaming loader #656
base: develop
Are you sure you want to change the base?
Streaming loader #656
Conversation
|
faceCounter = | ||
if data.faceCount | ||
then data.faceCount | ||
else file.size / averageFaceSize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't very readable. How about
faceCounter = if data.faceCount then data.faceCount else
file.size / averageFaceSize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works because data.number?
is always false in the first callback? Because otherwise progress = (data.number / faceCounter) * 80
will be NaN
.
How about initializing faceCounter = file.size / averageFaceSize
instead of 0?
Can't load binary stl that begin with solid keyword. |
No error message when loading an empty stl: And invalid stl: |
Can be reevaluated @stuikomma |
Fails to load bin STL that start with solid. Should retry as ASCII (as stated in thesis 😉).
|
Couldn't we add the heuristic that, say, a 10k character title is probably not an ASCII STL but a binary one that starts with the solid keyword and retry sooner? |
No description provided.