Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming loader #656

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Streaming loader #656

wants to merge 16 commits into from

Conversation

adius
Copy link

@adius adius commented Jun 25, 2015

No description provided.

@stuikomma
Copy link
Contributor

  • Error: Cannot find module 'filestream'
    This is not listed in oackage.json.

faceCounter =
if data.faceCount
then data.faceCount
else file.size / averageFaceSize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't very readable. How about

faceCounter = if data.faceCount then data.faceCount else
    file.size / averageFaceSize

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works because data.number?is always false in the first callback? Because otherwise progress = (data.number / faceCounter) * 80 will be NaN.

How about initializing faceCounter = file.size / averageFaceSizeinstead of 0?

@stuikomma
Copy link
Contributor

Can't load binary stl that begin with solid keyword.
Uncaught Error: Provided ascii STL is not closed with endsolid keyword

@stuikomma
Copy link
Contributor

No error message when loading an empty stl:
Uncaught Error: Provided STL-string must not be empty

And invalid stl:
Uncaught Error: Provided ascii STL contains an invalid solid

@adius
Copy link
Author

adius commented Jul 7, 2015

Can be reevaluated @stuikomma

@stuikomma
Copy link
Contributor

Fails to load bin STL that start with solid. Should retry as ASCII (as stated in thesis 😉).
Error message: Provided ascii STL is not closed with endsolid keyword

  • done

@stuikomma
Copy link
Contributor

Couldn't we add the heuristic that, say, a 10k character title is probably not an ASCII STL but a binary one that starts with the solid keyword and retry sooner?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants