Better size estimate for SpatialJoin
#1555
Merged
+32
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1555 +/- ##
==========================================
- Coverage 88.47% 88.46% -0.02%
==========================================
Files 364 364
Lines 27534 27540 +6
Branches 3714 3715 +1
==========================================
+ Hits 24362 24363 +1
- Misses 1940 1945 +5
Partials 1232 1232 ☔ View full report in Codecov by Sentry. |
…tialjoin-size-estimate
Conformance check passed ✅No test result changes. |
|
joka921
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now the
SpatialJoinclass always returned the product of the sizes of both children as its own size estimate. For a k-nearest-neighbor join this is usually way larger than the actual maximum size of the result. This PR implements a more precise size estimate.