Search summary support #41
Conversation
This was causing upserts to fail for me.
has become mandatory, needs a default ? to keep compatibility with existing script where may not be set.
now the join can be or not be specified, this not needed in generateLowerBoundFilter function
The sort boolean option for a search column appears to have never been created. It only ever sorts ASC by internalid regardless,This fixes that. Column can also be set ASC or DESC Descending: 'sort' = 'true' Ascending: 'sort' = 'false' Was not sure if to use string or bool , so went with string to fit in with the rest of the options. so 'true' works but true does not, this could be changed. If a column is set to sort, then the default internalid sort column is not added. With this patch multiple columns can be set to sort, though i have no idea if this works or not, compared with the readme stated action (which does not exist) to only sort by last column set to sort.
easy 'fix' to avoid problem of not being able to request limits on searches by internalId to make pages, when sorting by column other than internalId
Now joined columns go in their respective join titled array, to get around columns with same names from different joins clashing. Also (more for saved searches), a column assigned a label will override its default name, useful for preserving multiple same type formula columns.
Now joined columns go in their respective join titled array, to get around columns with same names from different joins clashing. Also (more for saved searches), a column assigned a label will override its default name, useful for preserving multiple same type formula columns.
Text and Value Support
I decided i need to keep conformity with the way the API returns variables rather than how this library has been specifying them (all lower case) Also a note, to really make things similar all the non-joined fields should be in a ['basic'] named array
really they should/could be merged....
Fix upsert typos - pull from wildkatana
trying to add an item sublist row to for example a sales order can return a SSS_INVALID_SUBLIST_OPERATION error, this is due to dynamic mode. way around it is to use setCurrentLineItemValue etc instead. this patch just checks for param bySelect in the sublist and uses this method instead, there may be other sublist types that need this, and a more comprehensive integration of these methods, but it works for me for now and thats enough for now...
available as elements in the 'record_data' request data object/array
Search filter join support
Search lower bound optional
Search column sort fix
Search column join groups and labels
Transform bug fixes
Upsert bug fixes
exposes the nlapiSubmitRecord doSourcing and ignoreMandatoryFields
|
@hayden-t I'm impressed this repo is still getting any activity at all. This project has been dead for nearly a decade and the company around it has been shut down for many years. I'm not even sure who owns the github organization account anymore. I can't speak for the company, I was just a developer there, but I'd say you should probably go ahead and run with your own fork. It's highly unlikely you'll get commits into this repo. Hey @fastjames or @JamesChristie are you conscious and do you know anything about the state of the Acumen repos? 💟 |
|
HA ! Its alive. Yeah I kinda already knew it was dead, I did get onto someone from acumen several years back, ill try and find the old email. Im more just doing pull requests so if anybody comes across the base repo they see there are extra features already coded if they dont look into the forks/network activity |
|
"Hello @hayden-t thanks for this update (though it is sad to hear). I read through your other issue posts, and you are correct that it would be good to move collaboration to a fork. Acumen Brands ceased operations several years ago, and the current org admins on github (me) don't use Netsuite right now. I'm very happy that others have been able to get some value out of our work, and I would be glad to push a README update on this repo directing interested parties to a fork." |
|
Yeah I'd definitely advocate for updating the README to point to your fork with a little bit of information. Happy Hacking! |
|
I just emailed james on his profile listed address if he doesnt get a ping from your post. :) Time flies, but this is still running live on our ecommerce all these years. |
|
I can reach both of the James if you need to reach out badly enough. Let's see what the ping does. |
|
james replied and confirmed he can make updates, not sure if to let him merge my pull requests into your repo or just have him link to my fork |
|
My vote would be to update the README and/or repo with a link to your fork but we'll see what shakes out. |
|
yeah my preference too, also if i am going to get a merge, i actually rather my main branch merged even though they are the same |
|
The README on this repo has been updated to point viewers to the active fork, so I hope that moves all the good activity to the proper place. I am glad to see that people are using what we wrote! |
https://docs.oracle.com/en/cloud/saas/netsuite/ns-online-help/section_N3117719.html