-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: maintain battery in a certain range #227
Conversation
Possibly closes #222 |
According to this if condition, It seems it will stop only once it's higher than upper_threshold
|
Yeah, forgive my misunderstanding, your code is correct :) |
@actuallymentor do you have time to merge this MR? |
Thanks a lot for your work @tangb4c! And apologies for my late response. My response times vary a lot depending on how busy work is :) The only request I have is to add a few extra comments explaining what your code does. I like to leave many comments so that new contributors can easily figure out what things do. Please tag me when you added them and I will gratefully merge! |
+1. May I request a GUI feature for this too? |
@tangb4c are you adding the remarks or would you like some 3rd party help with an update PR? :) |
Closing so we can keep this central in #261, if that was in error let me know! |
Allow battery tool to maintain battery between in a certain range.
Syntax: battery maintain min-max
Battery tool turn off charging above the maximum value, and on below the minimum value.
eg: battery maintain 20-70
eg: battery maintain 30-30