Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding note that templates using schedules need to be on the same line. #487

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

redshiftltd
Copy link

My first edit, I tried setting up a schedule in a template and had to trial and error to get it to link. I think this is clearer.

My first edit, I tried setting up a schedule in a template and had to trial and error to get it to link. I think this is clearer.
@actual-github-bot actual-github-bot bot changed the title Adding note that templates using schedules need to be on the same line. [WIP] Adding note that templates using schedules need to be on the same line. Nov 15, 2024
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for actualbudget-website ready!

Name Link
🔨 Latest commit 85a5f43
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget-website/deploys/67507e584f6a870007e7e29f
😎 Deploy Preview https://deploy-preview-487.www.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@youngcw
Copy link
Member

youngcw commented Nov 15, 2024

what do you mean by "on one line"?

@redshiftltd
Copy link
Author

The formatting in the table makes it look like you add {SCHEDULE NAME} on a new line in the category markdown. I'm attaching a screenshot.

Screenshot 2024-11-15 at 16 38 27

I'm on a big monitor, maybe it's just my browser.

@youngcw
Copy link
Member

youngcw commented Nov 15, 2024

This would apply to all the templates to show up as multiple lines in the table. Maybe this should be added somewhere else since its not specific to the schedule template.

@redshiftltd
Copy link
Author

redshiftltd commented Nov 15, 2024 via email

@youngcw
Copy link
Member

youngcw commented Nov 25, 2024

Your wording is saying that all templates must be on the same line, not just that a given template must be a single line. Could you update it to be clear its not just schedules and that its referring to a single template and not all templates?

@RubenOlsen
Copy link
Member

@redshiftltd, any comment on the feedback from @youngcw?

Changed phrasing, moved note to a new line instead as part of an existing note.
@redshiftltd
Copy link
Author

@youngcw I added the note as a new line and to me it looks clearer. Please take a look and tell me if it makes sense to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants