-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Adding note that templates using schedules need to be on the same line. #487
base: master
Are you sure you want to change the base?
Conversation
My first edit, I tried setting up a schedule in a template and had to trial and error to get it to link. I think this is clearer.
✅ Deploy Preview for actualbudget-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
what do you mean by "on one line"? |
This would apply to all the templates to show up as multiple lines in the table. Maybe this should be added somewhere else since its not specific to the schedule template. |
<!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:"Yu Gothic";
panose-1:2 11 4 0 0 0 0 0 0 0;}
@font-face
{font-family:Aptos;
panose-1:2 11 0 4 2 2 2 2 2 4;}
@font-face
***@***.*** Gothic";
panose-1:2 11 4 0 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:12.0pt;
font-family:"Aptos",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Aptos",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
-->Yes, I agree there. I didn’t want to push for too much so that’s why I put it as a footnote. From: youngcw ***@***.***>Date: Friday, November 15, 2024 at 17:06To: actualbudget/docs ***@***.***>Cc: redshiftltd ***@***.***>, Author ***@***.***>Subject: Re: [actualbudget/docs] [WIP] Adding note that templates using schedules need to be on the same line. (PR #487)This would apply to all the templates to show up as multiple lines in the table. Maybe this should be added somewhere else since its not specific to the schedule template.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Your wording is saying that all templates must be on the same line, not just that a given template must be a single line. Could you update it to be clear its not just schedules and that its referring to a single template and not all templates? |
@redshiftltd, any comment on the feedback from @youngcw? |
Changed phrasing, moved note to a new line instead as part of an existing note.
@youngcw I added the note as a new line and to me it looks clearer. Please take a look and tell me if it makes sense to you. |
My first edit, I tried setting up a schedule in a template and had to trial and error to get it to link. I think this is clearer.