-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electron package Typescript starting point #2880
Electron package Typescript starting point #2880
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
e78dd76
to
f320dae
Compare
…tch/actual into maintenance/ts-electron
…aintenance/ts-electron
…aintenance/ts-electron
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not able to run this locally:
...
build/static/js/ReportRouter.zdOroMmk.chunk.js 522.44 kB │ gzip: 138.70 kB │ map: 2,293.70 kB
build/static/js/index.SH_BeZNT.js 1,255.15 kB │ gzip: 386.63 kB │ map: 6,179.37 kB
✓ built in 23.07s
/Users/matiss/repos/actual/actual/node_modules/typescript/lib/tsc.js:114129
throw e;
^
RangeError: Maximum call stack size exceeded
at isStatementKindButNotDeclarationKind (/Users/matiss/repos/actual/actual/node_modules/typescript/lib/tsc.js:11149:46)
at isStatement (/Users/matiss/repos/actual/actual/node_modules/typescript/lib/tsc.js:11166:10)
at visitTypeScript (/Users/matiss/repos/actual/actual/node_modules/typescript/lib/tsc.js:85779:9)
at visitorWorker (/Users/matiss/repos/actual/actual/node_modules/typescript/lib/tsc.js:85668:14)
at saveStateAndInvoke (/Users/matiss/repos/actual/actual/node_modules/typescript/lib/tsc.js:85633:21)
at visitor (/Users/matiss/repos/actual/actual/node_modules/typescript/lib/tsc.js:85664:12)
at visitNode (/Users/matiss/repos/actual/actual/node_modules/typescript/lib/tsc.js:82976:19)
at visitEachChildOfBinaryExpression (/Users/matiss/repos/actual/actual/node_modules/typescript/lib/tsc.js:83711:26)
at visitEachChild (/Users/matiss/repos/actual/actual/node_modules/typescript/lib/tsc.js:83226:33)
at visitTypeScript (/Users/matiss/repos/actual/actual/node_modules/typescript/lib/tsc.js:85887:16)
Node.js v18.19.0
Deleted old |
Ok, cannot reproduce anymore. Works great 👍 So only one comment on the PR and then we can merge :) |
Sets up the desktop-electron package to use typescript. #1483
Main changes:
I haven't typed everything - I'm putting in the starting point in this PR.
The next step is to go through the electron files and convert them to typescript.