Maintenance: Updating icons generator to output typescript #1785
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset (largest 100 files by percent change)
View detailed bundle breakdownAdded
Removed
Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
MikesGlitch
changed the title
MikesGlitch
changed the title
|
I think using styled-icons would be a good move and would reduce the amount of code we need to maintain but I would like to see if all of the icons that we use are in that package. A POC would be great to see if that is the case. |
It looks like there are some icons in here that aren't in the latest Zondicons package - so on second thought, using a zondicons package might not be best. The icons seem like a mix of icon sets/self made. E.g. Our add icon is: But the Zondicon add is: There are lots of others too - there are some Zondicons icons and some are slightly different. I think it might be best to keep the system we have and convert them from svg using the script. I found that there are unused icons - mainly in the v1 folder. Do you think we should delete them or just leave them for future use? If we're happy leaving them, I think this PR's done. |
Tree-shaking is removing them from the output bundle, so I think it's fine to keep them. A bit of overhead.. but helps with future feature creation that need more icon diversity. |
trafico-bot
bot
added
✨ Merged
So we currently use: Zondicons. Right now we have about 368 generated files based on that icon set - that's why the pr is huge.
All these files are generated with the following command:
This PR just converts the js files to tsx.
To reduce the size of this PR we could delete the icons we don't use - that would make it harder when adding new icons to the UI in the future.
Another approach
We could use a package like styled-icons to get the zondicons into the project, and then delete all 368 of our icon files (because we'd be using the package instead). Then we wouldn't have to maintain these.
Open to thoughts
#1483