Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Schedules component in tsx #1644

Merged

Conversation

muhsinkamil
Copy link
Contributor

@netlify
Copy link

netlify bot commented Sep 3, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 6ca527b
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64f4fcf62b8aff000806b05c
😎 Deploy Preview https://deploy-preview-1644.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

}

async function onAction(name, id) {
// @todo: replace name: string with enum
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will make a follow-up PR for SchedulesTable and take care of it

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
14 2.12 MB → 2.12 MB (+42 B) +0.00%
Changeset
File Δ Size
src/components/schedules/index.tsx 🆕 +2.16 kB 0 B → 2.16 kB
src/components/common/Search.tsx 📈 +6 B (+0.45%) 1.3 kB → 1.31 kB
../loot-core/src/client/actions/budgets.ts 📉 -53 B (-0.97%) 5.34 kB → 5.29 kB
src/components/settings/Encryption.tsx 📉 -73 B (-2.25%) 3.16 kB → 3.09 kB
../loot-core/src/client/actions/modals.ts 📉 -76 B (-14.10%) 539 B → 463 B
src/components/schedules/index.js 🔥 -2.01 kB (-100%) 2.01 kB → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/wide-components.chunk.js 134.61 kB → 134.64 kB (+37 B) +0.03%
static/js/main.js 967.38 kB → 967.39 kB (+5 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/171.chunk.js 396.24 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/383.chunk.js 117.35 kB 0%
static/js/reports.chunk.js 40.52 kB 0%
static/js/narrow-components.chunk.js 24.44 kB 0%
static/js/969.chunk.js 12.94 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.12 kB 0%
static/css/main.css 5.82 kB 0%
asset-manifest.json 1.78 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 963 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.07 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.09 MB 0%
xfo.xfo.kcab.worker.js 1004.04 kB 0%

@muhsinkamil muhsinkamil changed the title [refactor] Schedules component in tsx WIP [refactor] Schedules component in tsx Sep 3, 2023
refactor: add types to actions modal

chore: add release-notes

refactor: add overload signature for modal type

refactor: remove changed typing to schedules-discover modal type

refactor: make Schedules component to tsx
@muhsinkamil muhsinkamil force-pushed the refactor/1483-schedules branch from 139285e to 6ca527b Compare September 3, 2023 21:39
@muhsinkamil muhsinkamil changed the title WIP [refactor] Schedules component in tsx [refactor] Schedules component in tsx Sep 3, 2023
Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment on lines +18 to +21
export function pushModal<M extends ModalType>(
name: M,
options?: FinanceModals[M],
): PushModalAction;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 praise: ‏nice!

@MatissJanis MatissJanis merged commit db07d7a into actualbudget:master Sep 4, 2023
17 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✨ Merged Pull Request has been merged successfully ✅ Approved labels Sep 4, 2023
@muhsinkamil muhsinkamil deleted the refactor/1483-schedules branch November 17, 2023 13:23
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants