Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Month count selector ts refactor #1565

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Month count selector ts refactor #1565

merged 4 commits into from
Aug 22, 2023

Conversation

Jod929
Copy link
Contributor

@Jod929 Jod929 commented Aug 22, 2023

Refactor /components/budget/MonthCountSelector to tsx. Related to issue #1483.

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 5cb7dfe
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64e4f2e71645cc00083aa66b
😎 Deploy Preview https://deploy-preview-1565.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
14 2.13 MB 0%
Changeset
File Δ Size
src/components/budget/MonthCountSelector.tsx 🆕 +1.01 kB 0 B → 1.01 kB
src/components/budget/MonthCountSelector.js 🔥 -1.01 kB (-100%) 1.01 kB → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 967.25 kB 0%
static/js/171.chunk.js 396.24 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/wide-components.chunk.js 137.2 kB 0%
static/js/383.chunk.js 117.35 kB 0%
static/js/reports.chunk.js 40.59 kB 0%
static/js/narrow-components.chunk.js 25.19 kB 0%
static/js/969.chunk.js 12.94 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.12 kB 0%
static/css/main.css 5.82 kB 0%
asset-manifest.json 1.78 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 963 B 0%

@github-actions
Copy link
Contributor

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 1.97 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1013.13 kB 0%
xfo.xfo.kcab.worker.js 1004.04 kB 0%

Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy review! Thanks :)

@MatissJanis MatissJanis merged commit 108c0a6 into actualbudget:master Aug 22, 2023
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Aug 22, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants