Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-82158/update-google-libphonenumber-to-the-latest-version #175

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

johnrb2
Copy link
Contributor

@johnrb2 johnrb2 commented Nov 22, 2024

Description of the change

bump google-libphonenumber to v3.2.28

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change
  • Technical Debt
  • Documentation

Related tickets

https://app.shortcut.com/active-prospect/story/82158/update-google-libphonenumber-to-the-latest-version

Checklists

Development and Testing

  • Lint rules pass locally.
  • The code changed/added as part of this pull request has been covered with tests, or this PR does not alter production code.
  • All tests related to the changed code pass in development, or tests are not applicable.

Code Review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • At least two engineers have been added as "Reviewers" on the pull request.
  • Changes have been reviewed by at least two other engineers who did not write the code.
  • This branch has been rebased off master to be current.

Tracking

  • Issue from Shortcut/Jira has a link to this pull request.
  • This PR has a link to the issue in Shortcut.

QA

  • This branch has been deployed to staging and tested.

@johnrb2
Copy link
Contributor Author

johnrb2 commented Nov 22, 2024

@henriquelakiap I think you mentioned some other stuff needed to be checked this was only a patch version update though. Is there anything else I should check that isn't obvious?

@henriquelakiap
Copy link
Contributor

@henriquelakiap I think you mentioned some other stuff needed to be checked this was only a patch version update though. Is there anything else I should check that isn't obvious?

I believe it was a local issue with npm link here after I updated the library. I ran lc-api after a fresh install using the local leadconduit-types with the updated library, and the error no longer occurred.

@johnrb2 johnrb2 merged commit a489fd9 into master Nov 27, 2024
2 checks passed
@johnrb2 johnrb2 deleted the sc-82158/update-google-libphonenumber-to-the-latest branch November 27, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants